celluloid doesn't install with requirements

gradhep / neos

Upstream optimisation for downstream inference

BSD 3-Clause "New" or "Revised" License

67 stars 5 forks source link

celluloid doesn't install with requirements #12

Open andrzejnovak opened 4 years ago

andrzejnovak commented 4 years ago

Shouldn't jupyter and nbdev also be part of requirements?

phinate commented 4 years ago

These are technically dev-only requirements (theyre also installed by default in the CI), but it is probably sensible to add at least jupyter, or explain this in CONTRIBUTING. Thanks!

andrzejnovak commented 4 years ago

Yup, adding it to CONTRIBUTING makes sense to me.