search

gradhep / neos

Upstream optimisation for downstream inference
BSD 3-Clause "New" or "Revised" License
69 stars 5 forks source link

update fit to new fax api #17

Open gehring opened 4 years ago

gehring commented 4 years ago

Currently requires using fax from the converge-test-override branch.

resolves #16

gehring commented 4 years ago

@lukasheinrich

phinate commented 4 years ago

Thanks for following things up with us @gehring! Indeed, neos is still very much active (and will continue to be) -- I've been getting my hands dirty with a refactor and redocumentation attempt on my own fork. Really appreciate your proactive issue raise.

Just FYI (for @lukasheinrich ), I did a quick test of this using fax@converge-test-override -- it definitely breaks something somewhere (loss is always 0 in the demo_softmax notebook, for example.)

The fit API will almost be unchanged with the refactor, so any solution found here will also be easy to merge down the line.

p.s. I've made sure to shout out you and fax in the 5 or 6 talks I've given on this :)

lukasheinrich commented 4 years ago

Thanks @gehring! I'll check this out in the next days.