Closed aliabid94 closed 1 year ago
Awesome PR @aliabid94! I left a lot of feedback since it's massive PR, but they're mostly pretty minor things. Overall, works great.
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:
pip install nbformat && cd demo && python generate_notebooks.py
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:
pip install nbformat && cd demo && python generate_notebooks.py
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:
pip install nbformat && cd demo && python generate_notebooks.py
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:
pip install nbformat && cd demo && python generate_notebooks.py
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:
pip install nbformat && cd demo && python generate_notebooks.py
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:
pip install nbformat && cd demo && python generate_notebooks.py
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:
pip install nbformat && cd demo && python generate_notebooks.py
I think I addressed every concern @abidlabs @freddyaboulton @aliabd, thanks for the feedback so far. if everything looks good to you guys, I'll merge in tomorrow
Add support for progressbar component. Feel free to leave feedback on API or visual design.
See example in demo/progress/run.py
Snippet for tqdm-like wrapper
Snippet for explicit status:
Closes: #340