search

gradio-app / gradio

Build and share delightful machine learning apps, all in Python. 🌟 Star to support our work!
http://www.gradio.app
Apache License 2.0
29.49k stars 2.19k forks source link

Only connect to heartbeat if needed #8169

Closed freddyaboulton closed 2 weeks ago

freddyaboulton commented 2 weeks ago

Description

Closes: #8022

Rather than always connecting to the heartbeat route, we should do so only when gr.State variables are used (to clean up state) or when the unload event is set. Users may still run into the browser limit, however.

EDIT: I originally wanted to raise an error or message when the page locked up due to the connection limit. But the browser will block all requests after the limit is reached so we won't be able to fetch the config and progressively load the app.

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

gradio-pr-bot commented 2 weeks ago

🪼 branch checks and previews

• Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
:unicorn: Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/97cfc159447ad8eb3b29f03aae8fa4484606e395/gradio-4.28.3-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@97cfc159447ad8eb3b29f03aae8fa4484606e395#subdirectory=client/python"
gradio-pr-bot commented 2 weeks ago

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/client patch
gradio patch

With the following changelog entry.

Only connect to heartbeat if needed

Maintainers or the PR author can modify the PR title to modify this entry.

#### Something isn't right? - Maintainers can change the version label to modify the version bump. - If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can [update the changelog file directly](https://github.com/gradio-app/gradio/edit/8022-connect-heartbeat-when-needed/.changeset/polite-lamps-burn.md).
abidlabs commented 2 weeks ago

Will this be compatible with gr.render() -- now that we can dynamically create components, a developer might include a workflow that dynamically creates gr.State() components?

The only other idea I can think of is to use long polling instead of a persistent SSE connection for the heartbeat

freddyaboulton commented 2 weeks ago

One of the reasons we did not use long-polling was that browsers can slow down timers so it could not be reliable. We're sending an updated config when the components are added in gr.render, I think we can recalculate the connect_heartbeat flag on every re-render.

freddyaboulton commented 2 weeks ago

Thanks for the reviews all!