gradio-app / gradio

Build and share delightful machine learning apps, all in Python. 🌟 Star to support our work!
http://www.gradio.app
Apache License 2.0
30.56k stars 2.27k forks source link

Fix multimodal textbox placeholder #8455

Closed dawoodkhan82 closed 3 weeks ago

dawoodkhan82 commented 3 weeks ago

Description

Fixes placeholder spacing when submit is clicked.

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

gradio-pr-bot commented 3 weeks ago

🪼 branch checks and previews

• Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
:unicorn: Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/d8164a21eb1bc7dd332549c16dfd72aa553eb499/gradio-4.32.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@d8164a21eb1bc7dd332549c16dfd72aa553eb499#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/d8164a21eb1bc7dd332549c16dfd72aa553eb499/gradio-client-0.20.1.tgz
gradio-pr-bot commented 3 weeks ago

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/multimodaltextbox patch
gradio patch

With the following changelog entry.

Fix multimodal textbox placeholder

Maintainers or the PR author can modify the PR title to modify this entry.

#### Something isn't right? - Maintainers can change the version label to modify the version bump. - If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can [update the changelog file directly](https://github.com/gradio-app/gradio/edit/placeholder/.changeset/quick-waves-train.md).
abidlabs commented 3 weeks ago

This fixes the issue in the default Gradio theme, but it seems that now the positioning of the multimodal textbox icons in the other themes is off again, reverting the fixes in: https://github.com/gradio-app/gradio/pull/8369. E.g. monochrome:

image

Can you confirm that a standard gr.ChatInterface(multimodal=True) works with all 5 of the built-in themes?

import gradio as gr

gr.ChatInterface(lambda x,y:x["text"], multimodal=True, theme="monochrome").launch()
abidlabs commented 3 weeks ago

I'm going to auto-merge this so that @aliabid94 can do a release if needed