gradio-app / gradio

Build and share delightful machine learning apps, all in Python. 🌟 Star to support our work!
http://www.gradio.app
Apache License 2.0
30.56k stars 2.27k forks source link

Added an optional `height` and overflow scrollbar for the Markdown Component #8528

Closed ShruAgarwal closed 6 days ago

ShruAgarwal commented 2 weeks ago

Description

Adds an option to enable the height parameter (type: str) for a scrollable markdown. This can be used for controlling the display size of this component.

Please run demo/markdown_example to see it in action.

I kindly request you @abidlabs to please review this change and let me know your feedback! 🙂

Closes: #7455

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

gradio-pr-bot commented 2 weeks ago

🪼 branch checks and previews

• Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
:unicorn: Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/76b87225d50105ee211814ade0222d719faef616/gradio-4.36.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@76b87225d50105ee211814ade0222d719faef616#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/76b87225d50105ee211814ade0222d719faef616/gradio-client-1.1.1.tgz
gradio-pr-bot commented 1 week ago

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/markdown minor
gradio minor

With the following changelog entry.

Added an optional height and overflow scrollbar for the Markdown Component

Maintainers or the PR author can modify the PR title to modify this entry.

#### Something isn't right? - Maintainers can change the version label to modify the version bump. - If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can [update the changelog file directly](https://github.com/ShruAgarwal/gradio/edit/scrollable-markdown/.changeset/tasty-coins-share.md).
ShruAgarwal commented 5 days ago

Looks great, thanks for this nice PR @ShruAgarwal! I made some tweaks for consistency with other components e.g. to make the height parameter also be able to accept an int.

Thanks a lot, @abidlabs ! 🤗😀