gradio-app / gradio

Build and share delightful machine learning apps, all in Python. 🌟 Star to support our work!
http://www.gradio.app
Apache License 2.0
30.56k stars 2.27k forks source link

Fix custom components on windows #8531

Closed freddyaboulton closed 1 week ago

freddyaboulton commented 2 weeks ago

Description

image

Closes: #6821 Closes: #7025

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

gradio-pr-bot commented 2 weeks ago

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
:unicorn: Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/86d007997fabacde4a0849a0cca29a97f125f799/gradio-4.36.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@86d007997fabacde4a0849a0cca29a97f125f799#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/86d007997fabacde4a0849a0cca29a97f125f799/gradio-client-1.1.1.tgz
gradio-pr-bot commented 2 weeks ago

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/preview patch
gradio patch

With the following changelog entry.

Fix custom components on windows

Maintainers or the PR author can modify the PR title to modify this entry.

#### Something isn't right? - Maintainers can change the version label to modify the version bump. - If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can [update the changelog file directly](https://github.com/gradio-app/gradio/edit/fix-cc-path-windows/.changeset/slick-ducks-fry.md).
pngwn commented 1 week ago

Does everything still work in mac/linux?

freddyaboulton commented 1 week ago

Yes tested on mac!

freddyaboulton commented 1 week ago

I guess the true test would be to do ship an release candidate of @gradio/preview but everything is working in the dev environment

freddyaboulton commented 1 week ago

Thank you @pngwn 🙏