search

gradio-app / gradio

Build and share delightful machine learning apps, all in Python. 🌟 Star to support our work!
http://www.gradio.app
Apache License 2.0
30.56k stars 2.27k forks source link

Ability to disable orange progress animation for generators #8543

Closed freddyaboulton closed 1 week ago

freddyaboulton commented 1 week ago

Description

The orange animation is always displayed for a generator. You may want to disable this. For example, in a chatbot demo where the text stream is enough indication that progress is being made. In this PR, the orange animation is only shown for generators if show_progress='full'. Also added show_progress for Interface and ChatInterface.

I thought there was an issue for this but I can't find it.

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

gradio-pr-bot commented 1 week ago

🪼 branch checks and previews

• Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
:unicorn: Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/d16c5c4abdd502ce459845e32b58a01420c767ba/gradio-4.36.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@d16c5c4abdd502ce459845e32b58a01420c767ba#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/d16c5c4abdd502ce459845e32b58a01420c767ba/gradio-client-1.1.1.tgz
gradio-pr-bot commented 1 week ago

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/statustracker patch
gradio patch

With the following changelog entry.

Ability to disable orange progress animation for generators by setting show_progress='minimal' or show_progress='hidden' in the event definition. This is a small visual breaking change but it aligns better with the expected behavior of the show_progress parameter. Also added show_progress to gr.Interface and gr.ChatInterface.

⚠️ The changeset file for this pull request has been modified manually, so the changeset generation bot has been disabled. To go back into automatic mode, delete the changeset file.

#### Something isn't right? - Maintainers can change the version label to modify the version bump. - If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can [update the changelog file directly](https://github.com/gradio-app/gradio/edit/show-progress-for-generators/.changeset/nasty-actors-kick.md).
freddyaboulton commented 1 week ago

Thanks for the review @aliabid94 !