Closed ShruAgarwal closed 1 week ago
• | Name | Status | URL |
---|---|---|---|
Spaces | Spaces preview | ||
Website | Website preview | ||
:unicorn: | Changes |
Install Gradio from this PR
pip install https://gradio-builds.s3.amazonaws.com/3677066afcb0f9333b65381fd11b55ee2b073bb1/gradio-4.36.1-py3-none-any.whl
Install Gradio Python Client from this PR
pip install "gradio-client @ git+https://github.com/gradio-app/gradio@3677066afcb0f9333b65381fd11b55ee2b073bb1#subdirectory=client/python"
Install Gradio JS Client from this PR
npm install https://gradio-builds.s3.amazonaws.com/3677066afcb0f9333b65381fd11b55ee2b073bb1/gradio-client-1.1.1.tgz
Package | Version |
---|---|
gradio |
patch |
Fixes the
favicon_path
working error
Maintainers or the PR author can modify the PR title to modify this entry.
Description
Trying to fix the bug related to
favicon_path
which doesn't seem to work when using it as a path forgradio.mount_gradio_app
and FastAPI.I've made the appropriate changes as suggested by @freddyaboulton on the issue:
""" It would be here:
https://github.com/gradio-app/gradio/blob/94a1143686733c7fe16e204764b9a3e7240ccf02/gradio/routes.py#L1222
We want to output a warning if
favicon_path
is notNone
and thepath
is not/
"""Closes: #8137
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh