Closed pngwn closed 2 years ago
Strong support for this, Model3D
or Scene3D
can be much better aligned to the CV community
I feel like naming Image3D
is better for a 3D Image, I don't get the feelings of a 3D Image from Model3D
Within the audience that would use this component, I think Model3D
is clearer. Image
implies 2D (or multichannel) data, while Model3D
is a bit clearer about working with a 3D object.
See https://pytorch3d.org/ which uses load_obj
for example, https://en.wikipedia.org/wiki/Wavefront_.obj_file which uses "3D geometry", https://en.wikipedia.org/wiki/GlTF which uses "three-dimensional scenes and models", or the recent Kubric https://github.com/google-research/kubric, which uses object as well. I don't think Image
is very aligned with the community that would use the component.
Can we also use this opportunity to fix the bug that prevents cached Image3d examples from being loaded?
Renamed in components.py
. Thanks @dawoodkhan82!
@osanseviero mentioned:
After a short discussion we felt that
Model3D
would be the best term as it is the most correct, despite this minor concern:We have only just released this component so usage will be low and with 3.0 around the corner changing the name should be pretty safe.