search

gradle / actions

A collection of GitHub Actions to accelerate your Gradle Builds on GitHub
https://github.com/marketplace/actions/build-with-gradle
MIT License
149 stars 39 forks source link

Output against which version of a wrapper JAR validation succeeded #285

Open sschuberth opened 4 years ago

sschuberth commented 4 years ago

In addition to know that a wrapper JAR successfully validated, it would also be nice to see in the console output which version was actually found to be a match.

JLLeitschuh commented 4 years ago

@sschuberth We are now intentionally attempting to minimize changes to the gradle-wrapper.jar file between releases. As such, there are now versions of the gradle-wrapper.jar that match multiple releases because the SHA-256 checksum won't have changed.

sschuberth commented 4 years ago

I see. Would it still make sense to output the most recent Gradle version the wrapper currently matches for?

JLLeitschuh commented 4 years ago

Theoretically, we could output a range of version matches. @eskatos what do you think?

@sschuberth what need are you looking to satisfy?

sschuberth commented 4 years ago

@sschuberth what need are you looking to satisfy?

I'm looking for some indication whether committed wrapper JARs might be outdated WRT the latest version available. If my committed wrapper JAR is the one from, say, Gradle 4.6, but my gradle-wrapper.properties points at Gradle 6.3, then it's quite likely that the wrapper JAR has been updated in between, and I might want to update it.

The background is that probably not many users are aware that running the wrapper task (once) does not update the wrapper JAR. Also see my PR https://github.com/gradle/gradle/pull/12671.

JLLeitschuh commented 4 years ago

That makes sense.

Somewhat outside the scope of this project, but I can see why that would be useful.

I'm happy to review a PR that adds this functionality if you want to contribute something.

sschuberth commented 1 year ago

I'm happy to review a PR that adds this functionality if you want to contribute something.

I don't think I'll ever find the time to implement this due to my non-existing TypeScript skills. So, should we close this, or leave it open for some one else to work on eventually?

bigdaz commented 2 months ago

Now that we have the wrapper checksums available locally, it should be pretty easy to implement this feature. I'll leave it open for now.