Defer token provider and migrate to com.gradleup.shadow

gradle / common-custom-user-data-gradle-plugin

Gradle plugin that enhances published build scans by adding a set of tags, links and custom values that have proven to be useful for many projects building with Develocity.

https://gradle.com/develocity

Apache License 2.0

42 stars 29 forks source link

Defer token provider and migrate to com.gradleup.shadow #299

Closed Goooler closed 2 months ago

Goooler commented 7 months ago

Follow up #298.

erichaagdev commented 2 months ago

Hi, @Goooler. Thank you for your contribution.

Can you revert the changes to settings.gradle.kts? For now, we've agreed as a team to keep with the eager APIs there. We will re-evaluate that decision once Gradle's remote build cache API migrates to using providers. Our preference is to use providers wherever possible, but it doesn't make sense to use providers.environmentVariable(...) when calling .isPresent immediately resolves it.

The changes in build.gradle.kts look fine. 👌

erichaagdev commented 2 months ago

Merged. Thanks again for your contribution @Goooler.