Completing subproject tasks does not work properly as it inserts the project name a second time

gradle / gradle-completion

Gradle tab completion for bash and zsh

MIT License

1.02k stars 131 forks source link

Completing subproject tasks does not work properly as it inserts the project name a second time #133

Open Vampire opened 1 year ago

Vampire commented 1 year ago

I'm on the latest commit 1c731fe54ca78c8df3e2456f6d5ac4d71c86f57e

go to the Gradle repository
enter ./gradlew build-cache-htt
press <TAB>
it gets completed to ./gradlew build-cache-http:
press <TAB> again
it gets completed to ./gradlew build-cache-http:build-cache-http:
you are at a dead end

clear the input line
enter ./gradlew :build-cache-http:reasona
press <TAB>
it gets completed to ./gradlew :build-cache-http:build-cache-http:reasonableDepsReportMain
you are at a dead end

Vampire commented 1 year ago

Ah, I used it on Git Bash from Git for Windows where no bash-completion is available: https://github.com/git-for-windows/git/issues/4366

Unfortunately the Gradle completion just ignores that problem and does faulty completion instead. Maybe the check should be changed, so that a warning is displayed if there is a colon in the result and the necessary function is not available instead of silently ignoring it and completing wrongly.

Vampire commented 1 year ago

Or maybe that function should be copied to the Gradle completion, as Git for windows will not fix it and I guess nowadays it is pretty common to run Gradle from Git Bash from Git for windows.