gradle / gradle-native

The home of Gradle's support for natively compiled languages
https://blog.gradle.org/introducing-the-new-cpp-plugins
Apache License 2.0
92 stars 8 forks source link

Fix deadlock issue when source dependency has buildSrc #899

Closed ghale closed 5 years ago

ghale commented 5 years ago

https://github.com/lacasseio/vscode-gradle-plugin/tree/lacasseio/exemplar has a source dependency on https://github.com/gradle/exemplar, which has a buildSrc. With the single project lock, this causes the buildSrc project to be built here while the project state registry lock is being held. This then creates a deadlock while the buildSrc build executes.

ghale commented 5 years ago

PR https://github.com/gradle/gradle/pull/7411

@lacasseio I verified that it fixes the issue with vscode-gradle-plugin - can you take a look at ☝️ ?

lacasseio commented 5 years ago

Looks good, Sterling already reviewed it and merged it. I merged release in master so I will close the issue.