search

gradle / gradle-native

The home of Gradle's support for natively compiled languages
https://blog.gradle.org/introducing-the-new-cpp-plugins
Apache License 2.0
92 stars 8 forks source link

Ignore operating system and architecture dimension in names when unambiguous #948

Closed lacasseio closed 5 years ago

lacasseio commented 5 years ago

When using something like this:

application {
    targetMachines = [machines.windows().x86_64(), machines.windows().x86()]
}

Or:

application {
    targetMachines = [machines.windows().x86_64(), machines.linux().x86_64()]
}

Expected Behavior

Task names and other named things should ignore the operating system in the first example and the architecture in the second example.

Current Behavior

Both are included in the named things.

Context

Steps to Reproduce (for bugs)

Your Environment

lacasseio commented 5 years ago

Some debt cleaning was split out in issue https://github.com/gradle/gradle-native/issues/954.

lacasseio commented 5 years ago

I miss understood a comment during the review and went on to do some work I outlined in this debt cleaning issue https://github.com/gradle/gradle-native/issues/955. I split out the work into separate PR https://github.com/gradle/gradle/pull/7893.