search

gradle / gradle-org-conventions-plugin

9 stars 6 forks source link

Ignore git output if no commit id can be parsed #4

Closed blindpirate closed 4 years ago

blindpirate commented 4 years ago 
Build scan background action failed.
com.gradle.scan.plugin.BuildScanUserDataValidationException: Build scan custom link url must be a well-formed http, https, or mailto URL (value: https://github.com/ljacomet/gradle/commit/[35mgpg: Signature made Mar  7 jul 17:38:22 2020 CEST
gpg:                using RSA key DD172346EE3674ACF207FF0527B0B98F8DE06180
gpg: Good signature from "Louis Jacomet <louis@gradle.com>" [unknown]
gpg:                 aka "Louis Jacomet (Main key) <ljacomet@gmail.com>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: DD17 2346 EE36 74AC F207  FF05 27B0 B98F 8DE0 6180
8b6f87e8b730d208ee4b471359d55510da59158c).

Currently we read the git commit via git rev-parse, and if this command outputs something else, the url will be rejected by build scan publishing. It should be more rubust.