File collections observed at configuration time should be detected as build configuration inputs

bamboo commented 2 years ago

As a motivational example, the kotlin-dsl plugin uses the file collection API to find all precompiled script plugins at configuration time and currently, the file collection must be explicitly marked as a build configuration input via an internal API: https://github.com/gradle/gradle/blob/049ee57264563a40c3cbcab6dddae58d9fd66b90/subprojects/kotlin-dsl-provider-plugins/src/main/kotlin/org/gradle/kotlin/dsl/provider/plugins/precompiled/DefaultPrecompiledScriptPluginsSupport.kt#L398-L406

Expected Behavior

The internal API call shouldn't be necessary for the file collection to be treated as a build configuration input.

TODO

[x] Remove explicit call from kotlin-dsl plugin
[ ] Query contents of configurable file tree and configurable file collection
[ ] Query contents of filtered and composite collections
[ ] Fix false cache misses - file content should be ignored
[ ] Query contents from buildSrc or plugin build
[ ] Query contents from project when configure on demand + project is used/not used

adammurdoch commented 1 year ago

adammurdoch commented 1 year ago

adammurdoch commented 1 year ago

Need to split this up into individual issues.