search

gradle / kotlin-dsl-samples

Samples builds using the Gradle Kotlin DSL
https://gradle.org/kotlin/
Other
3.71k stars 434 forks source link

Demonstrate buildSrc tests in samples #1087

Open jmfayard opened 6 years ago

jmfayard commented 6 years ago

According to the gradle guide, buildSrc should be preferred over script plugins as it is easier to maintain, refactor and test the code.

Yet none of the samples inside kotlin-dsl have a directory /buildSrc/src/test

So one hand we are on our own to figure out how it works, on the other hand it gives the impression that someone is not walking the walk.

StefMa commented 6 years ago

This have nothing to do with the Kotlin DSL. You should create/move this issue to the gadle/gradle repository when you think the samples needs to be improved. Providing a link to the specific documentation would also make sense...

On Sun, Sep 2, 2018, 10:11 AM Jean-Michel Fayard notifications@github.com wrote:

According to the gradle guide, buildSrc should be preferred over script plugins as it is easier to maintain, refactor and test the code.

Yet none of the samples inside kotlin-dsl have a directory /buildSrc/src/test

So one hand we are on our own to figure out how it works, on the other hand it gives the impression that someone is not walking the walk.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gradle/kotlin-dsl/issues/1087, or mute the thread https://github.com/notifications/unsubscribe-auth/AJwYeza5dW3eZqioj3G3mYYKw5NgEWK0ks5uW5KtgaJpZM4WWg2q .

jmfayard commented 6 years ago

This have nothing to do with the Kotlin DSL.

I am talking about those samples so yes it has to do something with the Kotlin DSL

https://github.com/gradle/kotlin-dsl/tree/master/samples

This is a lost occasion to teach by example and to show the benefits of the best practices