gradle / playframework

Gradle Play Support
https://gradle.github.io/playframework/
Apache License 2.0
47 stars 41 forks source link

Fix Gradle 6 warnings #114

Open PaulFridrick opened 4 years ago

PaulFridrick commented 4 years ago

I use Gradle 6 and the playframework plugin. All these warnings seem to come from the plugin:

lacasseio commented 4 years ago

Thanks for notifying us about those warning. Would you be willing to provide us some PRs to remove each warning? Ideally, it would be best to provide one PR per warning type simply because there may be a minimum supported Gradle version we want to support and the alternate API may not be available. This way we can more easily merge the PRs and provide releases without warning. Thanks a lot.

PaulFridrick commented 4 years ago

I have one more fix (see PR https://github.com/PaulFridrick/playframework/pull/1) that depends on the gradle 6 migration (PR https://github.com/gradle/playframework/pull/120), but it breaks the compatibility with Gradle 5 (the tests in InDepthUserGuideSamplesIntegrationTest fail with the versions "5.1.1", "5.2.1", "5.5.1" and "5.6.4").

aadrian commented 4 years ago

@PaulFridrick +1 for moving to Gradle 6.x and drop Gradle 5.

DPUkyle commented 4 years ago

My organization sees the following issue when building with 5.6.4:

image

I would prefer wrapping JavaScriptMinify line 44 with a version compatibility check. In pseudocode:

if (project.gradleVersion <= '5.1') {
  compilerClasspath = getProject().files()
} else {
  compilerClasspath = getProject().getObjects().fileCollection()
}

This same change would probably be necessary to all classes affected by this commit: https://github.com/gradle/playframework/commit/ef775a8f74cbb4539b8ea4c63321605962ddb7b3