search

gradle / test-retry-gradle-plugin

Gradle plugin to retry tests that have failed to mitigate test flakiness.
Apache License 2.0
224 stars 50 forks source link

Make build-cache-configuration config cache compatible #120

Closed JLLeitschuh closed 2 years ago

ldaley commented 2 years ago

Thanks Jonathan.

Can you please commit with your gradle.com address and sign it.

runningcode commented 2 years ago

Can we do this in a backward compatible with Gradle 5.x and 6.x? Many customers are stuck on older Gradle versions but still want to benefit from the insights of test-retry functionality.

etiennestuder commented 2 years ago

Can we do this in a backward compatible with Gradle 5.x and 6.x? Many customers are stuck on older Gradle versions but still want to benefit from the insights of test-retry functionality.

Strong +1

etiennestuder commented 2 years ago

Aren't there any Gradle-cross-version tests that would catch this?

JLLeitschuh commented 2 years ago

Supposedly, according to @wolfs this is no longer required in the latest version of Gradle. These API's have been deprecated in 7.4

runningcode commented 2 years ago

It would be good to implement this in order to get configuration cache compatibility while waiting for 7.4 but also for customers who aren't able to update to Gradle 7.4 (backward compatibility).

JLLeitschuh commented 2 years ago

This is exclusively a settings script change. It's not part of the code shipped to end users. There is no need to merge this if this build updates straight from 7.2 to 7.4