Compatibility with Gradle 8.0

gradle / test-retry-gradle-plugin

Gradle plugin to retry tests that have failed to mitigate test flakiness.

Apache License 2.0

228 stars 51 forks source link

Compatibility with Gradle 8.0 #148

Closed marcphilipp closed 2 years ago

marcphilipp commented 2 years ago

Motivation

A recent change to internal APIs in Gradle (https://github.com/gradle/gradle/pull/21919) broke compatibility.

A potential solution would be to add a copy(TestFilter): TestFramework method to TestFramework. Another workaround would be to use reflection to call the old or new constructor.

https://github.com/gradle/test-retry-gradle-plugin/blob/fd1933e424de5d79c1c5c1d18e31896fc0c90380/plugin/src/main/java/org/gradle/testretry/internal/executer/framework/JunitTestFrameworkStrategy.java#L27-L34

snoopcheri commented 2 years ago

I had a quick call with @jvandort :

a copy method on the TestFramework level makes the most sense
we have to see, whether we can define this method on the interface level (depends on required arguments for the specific test frameworks)
adding @UsedByScanPlugin("test-retry") on this additional method is also a very good idea
@snoopcheri will create a PR and add Justin, Sterling and Marc as reviewers - Justin will possibly add the whole core-team as reviewers

snoopcheri commented 2 years ago

PR in gradle/gradle: https://github.com/gradle/gradle/pull/22139 Draft PR in gradle/test-retry-gradle-plugin: https://github.com/gradle/test-retry-gradle-plugin/pull/149