Closed AlexeyAkentyev closed 9 months ago
Hi @leonard84, Thanks a lot for reviewing and accepting the proposed idea. Is it possible to release a new version with the fix? I rely on that functionality in the CI.
Yes, we'll release 1.5.7 in the next few days.
To be more precise it was released today.
Hi, I faced an issue that is quite critical for my day-to-day pipelines. I'm using Spock framework 2.x for different types of tests. While for independent tests methods 'MaxFailures' limit working just perfect it does not count failed spec annotated with Stepwise. It's quite a common case for e2e scenarios. Based on my research the issue is caused by
size()
implementation. https://github.com/gradle/test-retry-gradle-plugin/blob/235468201a9cd718e480c9eac4381e81eb4455f6/plugin/src/main/java/org/gradle/testretry/internal/executer/TestNames.java#L83 All scenario-level failures are sorted out as 'no failures'.How to reproduce: I've implemented a simple test that demonstrates the issue (in the
org.gradle.testretry.testframework.SpockBaseFuncTest
test)Potential fix: A very simple solution is to threat tests without failed test methods as '1' instead of '0' Implementation:
I'm also fully happy with any other solution that resolves the issue. Looking forward to your reply.
P.S. I'm happy to create a pull request. It would be super great if a fix will released as a minor version after the fix.