search

gradle / wrapper-validation-action

Gradle Wrapper Validation Action
https://github.com/marketplace/actions/gradle-wrapper-validation
MIT License
257 stars 57 forks source link

Upgrading Node.js to 20 #160

Closed LVMVRQUXL closed 7 months ago

LVMVRQUXL commented 11 months ago

Because Node.js 16 actions are deprecated, it could be nice to upgrade this action to Node.js 20.

Here's an example of workflow using gradle/wrapper-validation-action@v1.0.6 that shows the corresponding deprecation notice: Kotools Types Integration #370.

Thank you for considering this issue.

bigdaz commented 7 months ago

This fix is available in the v2.0.0-rc.1 release.

Please use gradle/wrapper-validation-action@v2 instead of v1.

LVMVRQUXL commented 7 months ago

This fix is available in the v2.0.0-rc.1 release.

Please use gradle/wrapper-validation-action@v2 instead of v1.

@bigdaz Do you have a visibility on when the version 2.0.0 will be available as a stable release (not only as a release candidate)?

TWiStErRob commented 7 months ago

Thank you @bigdaz! I already saw it ran successfully without warning on 10 repos from a few different orgs.

bigdaz commented 7 months ago

Do you have a visibility on when the version 2.0.0 will be available as a stable release (not only as a release candidate)?

@LVMVRQUXL Likely a week or so: just want to let it soak a little. Unless we experience issues, the final release will be from the same commit.

TWiStErRob commented 7 months ago

Note that by pushing v2 bots think that it's a stable release and most give no indication: https://github.com/detekt/detekt/pull/6918 (pinned Renovate) https://github.com/gradle-nexus/publish-plugin/pull/313 (non-pinned Renovate) https://github.com/hiteshprajapati/fineract/pull/109 (pinned Dependabot) https://github.com/syoon2/Project-Diagram-Generator/pull/47 (non-pinned Dependabot)

Only non-pinned Dependabot gets the release notes, so users see v2.0.0-rc.1 when they expand that.

Same happened with setup-gradle@v3