gradsflow / gradsflow-automl

An open-source AutoML Library based on PyTorch
https://docs.gradsflow.com/
Apache License 2.0
306 stars 35 forks source link

(PYL-W0613) Function contains unused argument #165

Closed aniketmaurya closed 2 years ago

aniketmaurya commented 2 years ago

Description

An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.

Occurrences

There are 5 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/gradsflow/gradsflow/issue/PYL-W0613/occurrences/

skp-github commented 2 years ago

It is something that needs to be fixed (i mean it's not done yet)?

aniketmaurya commented 2 years ago

Hi @skp-github! first of all, thanks for checking the issues. This issue is intentional and we have to add rules in Deepsource to ignore this. You can help us by raising a PR for this. Here is a documentation on how to silence this issue.

skp-github commented 2 years ago

@aniketmaurya Thank you for the reply. I will try to see and raise a PR for the same(I'm kind a new to the project just need to get my self familiar), can you suggest few links to understand more about gradsflow ?. Is there any list of expected/required features list which i can work on as well ?. Also I think you will happy to know that I work for a research lab which is using gradflow for a lot of neurophysiological research :)

aniketmaurya commented 2 years ago

@skp-github Some of the resources to learn more about Gradsflow are -

__(If you find something unexpected feel free to reach out in our community Slack channel)__

For a new feature, maybe you can check this issue.

Also, it is great to know that Gradsflow is being used at a research lab. If you don't mind I would love to know more about it.

skp-github commented 2 years ago

@aniketmaurya I'm sorry if i understood it incorrectly but this specific issue seems to be resolved already (i.e skipcp signal is already there tuner/automodel.py line 77 ) but i can see anti pattern issues at https://deepsource.io/gh/gradsflow/gradsflow/issues?category=antipattern&analyzer=all&page=1, do you want me to fix them and generate a PR because, unused variable one is not fixed yet. Please guide me on this. Also, sure i will connect with you over the slack channel and I can give you details about the lab and other details :)

aniketmaurya commented 2 years ago

I think most of the issues in deepsource are false positive or intentional so I would recommend to leave that one. There are some other issues/feature request if you would like to work on?

skp-github commented 2 years ago

@aniketmaurya for the first part, i fixed two small anti pattern issues, i have few questions about the PR process (it's fine if you don't accept the PR once i generate it but i will have an idea how the flow works, i will ask you my questions on slack). Second part, yes i would love to work on the feature request or issues if you have some kind list or anything similar(if you are not talking about the ones which are already listed as issues ).

github-actions[bot] commented 2 years ago

Stale issue message