grae22 / TeamTracker

MIT License
0 stars 0 forks source link

Settings button/link #7

Closed j-broo closed 7 years ago

j-broo commented 7 years ago

Add settings icon in top right to take user to a management page, with the ability to add/edit/delete person entries. May add additional settings there. Should require a login. DB login would suffice.

Hopefully doesn't clutter main interface.

grae22 commented 7 years ago

Implemented basic settings page with login step (default password is 'admin').

grae22 commented 7 years ago

Made some changes to settings table while doing this.

j-broo commented 7 years ago

I don't see the need for the delete option. Do we really want people to be able to delete an entire setting? Perhaps a 'clear' option, although I think 'edit' would suffice, if they want to clear it they can save an empty text box, as empty values are not really encouraged.

Key field should not be editable.

Deleting the entire row has potential to break the software, which it did when I deleted the SettingsPassword key.

grae22 commented 7 years ago

So the settings will all be predefined, just the values editable?

j-broo commented 7 years ago

I think so. When would they need to be editable? That's why i never included the key column initially, expected to rely on the Id column to identify the setting.

I suppose the DB would have a bunch of defaults that you can edit.

grae22 commented 7 years ago

Ditched the delete option.

grae22 commented 7 years ago

Oh should prob ditch the new button, too.

grae22 commented 7 years ago

Ditched it.

j-broo commented 7 years ago

I think the cog button should go, and we go for a 'settings' link bottom right under the table? same line as the version number etc?

grae22 commented 7 years ago

Cool.

grae22 commented 7 years ago

Done.

j-broo commented 7 years ago

Settings link is fine. No need for further work here.