grae22 / TeamTracker

MIT License
0 stars 0 forks source link

Multiple contact options: SIP/Tel/Email #8

Closed j-broo closed 7 years ago

j-broo commented 7 years ago

Ability to select a contact protocol from settings page. Global setting. Choose from either SIP, Tel or Email.

Setting stored in settings table. Suggest doing this by loading URL prefix string from table and creating link dynamically, so either 'sip:', 'tel:', or 'mailto:'

Setting doesn't need to be per-person.

grae22 commented 7 years ago

Just a thought... in read-only mode, clicking on a status (probably only 'yes' statuses) could do this. So, any 'yes' statuses are also hyperlinks with relevant sip/tel/mailto address.

j-broo commented 7 years ago

I'm not sold on reusing the buttons for this, i think it has the potential to be confusing. I think it would be better to leave those to the sole purpose of enabling/disabling status.

Perhaps we can update main page to replace tel no with a contact button. When clicked it allows selection of sip/tel/email?

The initial idea behind having the contact number visible was to cater for people who may not be using a softphone, as it gives a visual reference for the number. May still be feasible if clicking on the 'contact' button displays the extention/tel no/email address?

grae22 commented 7 years ago

Yeah +1 on confusion.

grae22 commented 7 years ago

Tooling around with dropdown, see http://teamtrackerexperimental.azurewebsites.net/Default.aspx for demo. Looks crappy, but concept?

grae22 commented 7 years ago

Updated the experimental ver, drop simply displays 'email' & 'skype'.

grae22 commented 7 years ago

Still need to add setting for default contact type which will influence what is displayed in contact column and what shows in the dropdown.

grae22 commented 7 years ago

Added setting (prev comment) to experimental ver.

j-broo commented 7 years ago

Drop-down looks super rad. Liking the transparency and lack of clutter. Can't click out of it though. OK... i see you can by clicking the arrow again...

grae22 commented 7 years ago

I'll bring it into the master branch when I get a mo, entails some db changes.

grae22 commented 7 years ago

Have integrated dropdown into master.

grae22 commented 7 years ago

Anything else we need on this?

j-broo commented 7 years ago

Dropdown doesn;t display properly on some browsers. dropdown

My BB10 browser and the bulit-in browser on our SIP client. not sure what that is based on.

grae22 commented 7 years ago

Pushed potential fix to experimental site.

grae22 commented 7 years ago

Fix merged into master.

j-broo commented 7 years ago

Just a thought, perhaps skype link should start a chat?

See here: http://stackoverflow.com/questions/2841676/how-to-start-skype-chat-not-call-with-link

My intention was that at least.

For the tel: prefix we should alternate that with sip: or have a separate call option for example for cell/landline no. I know i can set my sip client to dial tel: links instead of skype doing it.

grae22 commented 7 years ago

Ja I like that for skype chat.

So cols for cell/landline, skype-call & skype-cat?

j-broo commented 7 years ago

I reckon lets offer sip/tel:, mailto and skype chat?

grae22 commented 7 years ago

You want to be able to choose between sip & tel within the same 'column' (on the main page)?

j-broo commented 7 years ago

I'll have to test. I think sip: dials any number if you have a sip client installed. Tel: is specifically a skype or similar thing. I'll confirm...

j-broo commented 7 years ago

OK sip and tel seem to be kind of interchangeable. On PC, tel launches whatever the default app for the link is. In my case, skype. On mobile, it initiates a call. So I think let's leave it to the user to choose in the import file, no need to have separate contact options.

grae22 commented 7 years ago

Cool, so nothing more to do here?

j-broo commented 7 years ago

No, i think this is done. We can deal qith any glitches etc later if they crop up.