search

graememcc / micropolisJS

A port of Micropolis to JS/HTML5
Other
647 stars 95 forks source link

added A 'return' to growZone method #27

Closed emalron closed 6 years ago

emalron commented 6 years ago

I found a bug which a residential zone was getting bigger without any effort. R-Zones need high population density to be promoted from 'FREEZ' tile.

At line 126 in Residential.js, the conditional statement checks if the residential zone meet the requirement to grow population. and the program should be escaped growZone method when one is failed the population density check.

previous version keep going to the next conditional statement, so the R-Zones can keep growing its population with low density.

graememcc commented 6 years ago

Thank you so much for this pull request, and spotting these logic errors! I'll bet the temp map clearing helps with issue #21.

After I merge this, I'm going to push a follow-up commit, as there was some commented out console logging left in there (I do that all the time!). The else branch in BlockMapUtils.js looks unnecessary now after your fix, so I might get rid of that too.

I'll try to have the version with your changes up on my URL within the next half-hour from time of writing.

Sorry I took so long to get to this, and thanks, once again!

graememcc commented 6 years ago

Should now be live at http://graememcc.github.io/micropolisJS