graetzer / GDataXML-HTML

HTML and XML parser for iOS and OSX, supports XPath
Apache License 2.0
289 stars 121 forks source link

Fixes crash with qualified name for entity node #15

Closed artemyarulin closed 8 years ago

artemyarulin commented 8 years ago

Fixes #14

graetzer commented 8 years ago

Seems fine to me, if you want you can merge it

graetzer commented 8 years ago

But why is the travis build not passing?

artemyarulin commented 8 years ago

Hm, weird.

ns-crash/build21 is broken because it has only the test for the error ns-crash/build22 has a fix and passed as it should be PR/build23 - just a pull request of the same branch and failed, wtf main/build24 - but when it was merged to the master everything went ok

I'll try to re-run build 23 and see

artemyarulin commented 8 years ago

Well, pull request was accepted and removed so Travis cannot find it and re-build.

Don't know what else I can do here. Master is stable at least