search

grafadruid / druid-grafana

Connects Grafana to Druid
https://join.slack.com/t/grafadruid/shared_invite/zt-1qy0skzy8-axnZuyzaWRm9t8f0r9dUWQ
Apache License 2.0
63 stars 36 forks source link

Datasketches support (`quantilesDoubleSketch`) #94

Open jln-pl opened 3 years ago

jln-pl commented 3 years ago

Hi! I see that you have a druid-datasketches extension.

Are you going to add aggregator and post aggregators for quantilesDoubleSketch?

jbguerraz commented 3 years ago

Hello @jln-pl Thank you for this issue! We would be happy to support that extension, first of all it would need support on the go-druid side of the plugin, mostly like what was done for tdigest sketch (see https://github.com/grafadruid/go-druid/commit/533761d2edab2d9efdf7c1a0d5e0c35abd743775) and then we would need to add the components in this plugin. my team and I won't have time (and need) for such extension support in a short to mid term, but I'd be happy to help you contribute that feature! that would be awesome! it requires only minimal coding skills, no rocket science and maybe few hours of effort :) WDYT ?

jln-pl commented 3 years ago

I will try to do it in my spare time ;)

jbguerraz commented 3 years ago

I'll be happy to help @jln-pl ! feel free to ping me on Slack for support :)

san-san commented 2 years ago

With https://github.com/grafadruid/go-druid/pull/60 merged, Am I correct in saying that we only need changes in the plugin components to support quantilesDoubleSketch?

jbguerraz commented 2 years ago

@san-san Yes, we need to add an aggregator component (https://github.com/grafadruid/druid-grafana/tree/master/src/builder/aggregation) and a post aggregation (https://github.com/grafadruid/druid-grafana/tree/master/src/builder/postaggregation) one.

san-san commented 2 years ago

Quick update, I have a working solution that we're testing now. We'll raise a PR shortly. https://github.com/san-san/druid-grafana/releases/tag/v1.3.0_beta if you'd like to try it out.

Note: quantilesDoublesSketchToQuantiles (https://druid.apache.org/docs/latest/development/extensions-core/datasketches-quantiles.html#quantiles) has not been implemented in go-druid.

Once my current change has been accepted and merged I can work on that.

jbguerraz commented 2 years ago

Hello @san-san Any chance you moved ahead with it ? need some support ?

jbguerraz commented 1 year ago

just in case @san-san if you forgot this but actually made some progress :)