search

grafana-toolbox / grafana-client

Python client library for accessing the Grafana HTTP API.
MIT License
106 stars 30 forks source link

Refine API wrapper for "Plugins" once more #115

Closed amotl closed 1 year ago

amotl commented 1 year ago

About

After GH-110 and GH-114, this patch streamlines the API wrapper about "plugins" a bit more.

Details

  1. The patch is needed to make https://github.com/panodata/grafana-wtf/pull/91 work.

  2. While at it, it also adjusts/trims the method names a bit. I hope it will not cause too much harm, because the feature has only been released recently. I don't think we need to bump to 4.0.0 to properly signal that "breaking" change. I would just run a 3.9.0 release to ship it. Please let me know if you think differently.

/cc @bhks

codecov[bot] commented 1 year ago

Codecov Report

Merging #115 (402cb5e) into main (05759df) will decrease coverage by 0.75%. Report is 3 commits behind head on main. The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   94.85%   94.11%   -0.75%     
==========================================
  Files          25       25              
  Lines        1594     1613      +19     
==========================================
+ Hits         1512     1518       +6     
- Misses         82       95      +13
Files Changed Coverage Δ
grafana_client/elements/plugin.py 58.18% <54.16%> (-9.27%) :arrow_down:
grafana_client/client.py 95.69% <55.55%> (-4.31%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more