Adding support for service account

grafana-toolbox / grafana-client

Python client library for accessing the Grafana HTTP API.

MIT License

107 stars 30 forks source link

Adding support for service account #139

Closed einar-lanfranco closed 10 months ago

einar-lanfranco commented 11 months ago

Description

We include support for service account, its parcial, but you can:

Add and remove service account
Add and remove tokens to service account
Add permisson to a service account to a folder
Searcha service account

Checklist

[ ] The patch has appropriate test coverage
[X ] The patch follows the style guidelines of this project
[ X] The patch has appropriate comments, particularly in hard-to-understand areas
[ X] The documentation was updated corresponding to the patch
[ X] I have performed a self-review of this patch

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2d3bb21) 94.18% compared to head (d661e89) 94.43%. Report is 7 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #139 +/- ## ========================================== + Coverage 94.18% 94.43% +0.25% ========================================== Files 25 26 +1 Lines 1633 1707 +74 ========================================== + Hits 1538 1612 +74 Misses 95 95 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

amotl commented 10 months ago

Dear Einar, I just wanted to add that you just need to let us know if you want us to take over. Cheers, Andreas.

amotl commented 10 months ago

Hi again. We will take over your PR in order to wrap it up and release the improvements together with GH-143. We hope this is fine.

amotl commented 10 months ago

Dear Einar and Fermin,

I've reworked the patch a bit. Thanks again for the contribution, it will be part of the next release.

With kind regards, Andreas.