search

grafana-toolbox / grafana-wtf

Grep through all Grafana entities in the spirit of git-wtf.
GNU Affero General Public License v3.0
159 stars 16 forks source link

Add notification channels #106

Closed nikodemas closed 8 months ago

nikodemas commented 1 year ago

I have added notification channels section into the find command. However, I still haven't updated the index functions, so my issue is still not solved with this PR as the notification channels are not being attached to the dashboards. Therefore, marking this as draft till I update the index part.

nikodemas commented 10 months ago

@amotl I just realized that unlike as it is for the data sources, where the full name of the data source is presented in the dashboard, alert channels are presented only by their uid. Also, with the alerting in Grafana being unified in the version 8 the alerting system differs quite a bit across the different versions. Finally, notification channels (or contact points) do not seem to be important enough to be a default printout for the find command. For these reasons, I will revert most of the changes in this PR and will keep only the minimal version of changes and I think that the issue https://github.com/panodata/grafana-wtf/issues/82 can be closed.

nikodemas commented 10 months ago

So basically this PR doesn't differ anymore from the https://github.com/panodata/grafana-wtf/pull/105 except for the changes in grafana_wtf/report/textual.py which are completely unrelated to the notification channels - I just noticed that there is a bug in the textual output as data sources get a prefix of Dashboard instead of Data Source. I guess we could rename this PR or I could close this PR and create a new one only for this change. Let me know what you think.

amotl commented 10 months ago

Dear @nikodemas,

thank you for making progress on this. If you trimmed down your patch, and the outcome is just an unrelated fix, I am humbly asking you to hand in a separate PR.

Thanks a stack and with kind regards, Andreas.

amotl commented 8 months ago

Hi again. At GH-114, you told us to close this PR. Is it true, don't we need it?

nikodemas commented 8 months ago

Yes, I am closing it. Thanks for the reminder!