search

grafana-toolbox / grafana-wtf

Grep through all Grafana entities in the spirit of git-wtf.
GNU Affero General Public License v3.0
159 stars 16 forks source link

Accept `datasource` attribute on `DatasourceItem`, but ignore it #131

Closed amotl closed 2 months ago

amotl commented 8 months ago

About

Dear @apepojken. This patch intends to poke at the details based on your report.

Details

When I try to explore datasources it always fail with a TypeError. No idea why this happens.

Exception:

TypeError: DatasourceItem.__init__() got an unexpected keyword argument 'datasource'

Thoughts

It is unlikely that this is the correct fix. It hasn't been validated in any way, so it is purely based on guessing, not even educated. We will ask a few more questions at GH-110.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.32%. Comparing base (e6d0783) to head (81ed006). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #131 +/- ## ========================================== + Coverage 87.15% 87.32% +0.17% ========================================== Files 9 9 Lines 1082 1089 +7 ========================================== + Hits 943 951 +8 + Misses 139 138 -1 ``` | [Flag](https://app.codecov.io/gh/grafana-toolbox/grafana-wtf/pull/131/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/grafana-toolbox/grafana-wtf/pull/131/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `87.32% <100.00%> (+0.17%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

amotl commented 8 months ago

We verified the status on play.grafana.org, without the patch, and there haven't been any issues.

Therefore, we are hibernating this patch back into draft mode.

amotl commented 2 months ago

We are merging this patch, because it solves a user's problem. Thanks again, @apepojken.