grafana-toolbox / grafana-wtf

Grep through all Grafana entities in the spirit of git-wtf.
GNU Affero General Public License v3.0
138 stars 12 forks source link

Fix caching after migration to Niquests #135

Closed amotl closed 3 months ago

amotl commented 3 months ago

That other patch did not get everything right wrt. proper caching. This one fixes it, applying suggestions by @Ousret. Thanks!

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.17%. Comparing base (5eabef0) to head (3818da8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #135 +/- ## ========================================== - Coverage 87.24% 87.17% -0.08% ========================================== Files 9 9 Lines 1082 1076 -6 ========================================== - Hits 944 938 -6 Misses 138 138 ``` | [Flag](https://app.codecov.io/gh/panodata/grafana-wtf/pull/135/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panodata) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/panodata/grafana-wtf/pull/135/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panodata) | `87.17% <100.00%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panodata#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.