search

grafana-toolbox / grafanimate

Animate timeseries data with Grafana.
https://community.panodata.org/t/grafanimate/205
GNU Affero General Public License v3.0
47 stars 7 forks source link

Debian Firefox ESR not used #18

Open gogglespisano opened 1 year ago

gogglespisano commented 1 year ago

On Debian, Firefox ESR is normally installed. In /usr/bin/ there is "firefox" and "firefox-esr". When find_firefox() sees "firefox", it tries to use it and fails. It needs to find and try "firefox-esr" first.

The follow change in marionette.py line 111 fixes the problem, and should still work for a regular firefox installation.

def find_firefox(cls):
    candidates = where.where("firefox-esr")
    candidates += where.where("firefox")
    candidates += [
        "/Applications/Firefox.app/Contents/MacOS/firefox-bin"
    ]
amotl commented 1 year ago

Dear Stuart,

apologies for the late reply. We just added f78451198a2fa, after the same problem tripped @intermittentnrg when running grafanimate in Docker.

With kind regards, Andreas.

maurerle commented 2 days ago

could you please release this to pypi as well?