search

grafana-toolbox / panodata-map-panel

Map Panel for Grafana with improved convenience, robustness and features. Friendly fork of the original Grafana Worldmap Panel. Currently not maintained, but verified to work up to Grafana 9.
https://community.panodata.org/t/grafana-map-panel/121
GNU Affero General Public License v3.0
88 stars 31 forks source link

Grafana 8: Don't croak when unable to load/access KeybindingSrv #104

Closed amotl closed 3 years ago

amotl commented 3 years ago

Hi there,

this addresses #103.

Apparently, the KeybindingSrv service component will have to be addressed differently on Grafana 8. By now, the first patch 86d5db3 will just ignore / skip anything related to that, so we only lack minor functionality about »disabling keyboard navigation completely«, aka. the ignoreEscapeKey feature.

While this is a start, there might be more issues we will be running into, so we will be happy to receive any further reports from the community. Would someone also be available to verify this by building that branch using npx yarn dev and linking the dist folder into the Grafana plugin folder in order to check if the plugin with those improvements will actually work on real data?

With kind regards, Andreas.

/cc @jm66, @MarcoPignati

birdayz commented 3 years ago

i'd be happy to test with real data - having it available as release 0.15.1 would help!

jm66 commented 3 years ago

Hello @amotl,

Thank you. Just tested it and works great with Grafana v8.0.1 (8849243d27).

Thanks, JM

francescobianca commented 3 years ago

@jm66 Could you send me a compiled version compatible with Grafana 8?

andsens commented 3 years ago

@francescobianca

Could you send me a compiled version compatible with Grafana 8?

Take a gander here https://github.com/panodata/grafana-map-panel/issues/103#issuecomment-875399946

jm66 commented 3 years ago

@francescobianca my apologies. I was out of the office but @andsens saved the day - thank you!

amotl commented 3 years ago

Hi there,

finally, I have been able to find some time to issue the regular release (0.16.0), see https://github.com/panodata/panodata-map-panel/releases/tag/0.16.0. We will be happy to receive any feedback how this version works.

Please note that the plugin name changed to panodata-map-panel in order to support #112.

With kind regards, Andreas.