grafana-toolbox / panodata-map-panel

Map Panel for Grafana with improved convenience, robustness and features. Friendly fork of the original Grafana Worldmap Panel. Currently not maintained, but verified to work up to Grafana 9.
https://community.panodata.org/t/grafana-map-panel/121
GNU Affero General Public License v3.0
88 stars 31 forks source link

Problems with Grafana 7.5.2 #95

Closed amotl closed 3 years ago

amotl commented 3 years ago

Hi there,

at https://github.com/Safecast/safecastapi/issues/795, @matschaffer reported about problems with this map panel on Grafana 7.5.2. When the display should happen, it now says Error loading: grafana-map-panel.

image

I would like to gather more information about that.

Recently, we upgraded to Grafana 7.4 [1] and have not been able to detect any problems so far. However, we are mainly using InfluxDB. So, I would like to investigate whether there is something specifically to Grafana 7.5 (vs. 7.4) or if the problem might originate from the matter of using Elasticsearch as a data source.

With kind regards, Andreas.

[1] https://community.hiveeyes.org/t/giving-the-backend-software-infrastructure-some-love/3839

amotl commented 3 years ago

@matschaffer and @robouden: Maybe there is something on the JavaScript console which might give us a clue about the origin of the problem. If so, can you share the relevant output here?

matschaffer commented 3 years ago

Thanks for the issue! I’m going to have to reproduce it first. I’d originally tried the upgrade on our main site so had to roll back quickly.

On Wed, Mar 31, 2021 at 18:47 Andreas Motl @.***> wrote:

@matschaffer https://github.com/matschaffer: Maybe there is something on the JavaScript console which might give us a clue about the origin of the problem? If so, can you share it here?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/panodata/grafana-map-panel/issues/95#issuecomment-810932935, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAFMWAX42VLZ7AL3DQ5JTTGLVUHANCNFSM42EGZMVA .

--

-Mat

matschaffer.com

amotl commented 3 years ago

Thanks for the issue! I’m going to have to reproduce it first.

You are welcome and take your time. I will start investigating afterwards.

I’d originally tried the upgrade on our main site so had to roll back quickly.

Sure. May I ask to which version you rolled back? 6.x?

matschaffer commented 3 years ago

7.5.1 - so must be something very recent causing the break. It could be the elasticsearch data source even. There have been folks working on that lately.

amotl commented 3 years ago

7.5.1 - so must be something very recent causing the break.

Oh, then this is pretty obvious. This information is important, thank you.

It could be the elasticsearch data source even. There have been folks working on that lately.

All right, good to know. So either the downstream components (like this plugin) will have to adjust, or, alternatively, we should watch out for eventual fixes on that that would probably go into another bugfix release 7.5.3 then.

amotl commented 3 years ago

The release notes for Grafana 7.5.2 look pretty much innocent from my perspective, but you never know.

Maybe https://github.com/grafana/grafana/pull/32290 is related?

The other update on ES I found happening between 7.5.1 and 7.5.2 was https://github.com/grafana/grafana/pull/32282. However, @Elfo404 said about this:

I tested this using Elasticsearch 2 as well as 7 (from our devenv) and it seems to work for both of them.

matschaffer commented 3 years ago

Screen Shot 2021-04-05 at 8 05 09

Seems fine now. Must have just been something with my connection. Sorry for the noise @amotl - I'd say you can close this.

amotl commented 3 years ago

Thank you for reporting back about this, Mat. I am happy that this plugin is still compatible with the most recent Grafana 7.x release.