search

grafana / agent

Vendor-neutral programmable observability pipelines.
https://grafana.com/docs/agent/
Apache License 2.0
1.6k stars 487 forks source link

Support Go 1.19 #1983

Closed andig closed 2 years ago

andig commented 2 years ago

https://github.com/Homebrew/homebrew-core/pull/107165 fails due to 

panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.19 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.19 set. Notably, if go1.19 adds a moving garbage collector, this program is unsafe to use.

This can be fixed by upgrading go4.org/unsafe/assume-no-moving-gc according to https://github.com/lucas-clemente/quic-go/issues/3491

rfratto commented 2 years ago

Thanks, #1985 should take care of this. Will this block updating the Go formula to 1.19? We typically release a new version of Grafana Agent every six weeks, but we can figure something out if this is needed urgently.