search

grafana / agent

Vendor-neutral programmable observability pipelines.
https://grafana.com/docs/agent/
Apache License 2.0
1.56k stars 479 forks source link

chore(faro): prefix measurement values when parsing faro measurements #6810

Closed codecapitano closed 3 weeks ago

codecapitano commented 2 months ago

PR Description

This PR aligns the hot to translate Faro measuerements with the latest Faro cloud receiver updates.

For reference have a look at the https://github.com/grafana/app-o11y-kwl-endpoint/pull/397.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

codecapitano commented 2 months ago

Hi @wildum 👋 I have no permission to merge the branch. How's the process here, just ping the agent team or will automatically be merged at some time?

wildum commented 2 months ago

Hey sorry for dragging this up, we just made the Alloy repo public and we need to redirect the PRs there. We will only be merging bugfixes to the agent from now on. We are just figuring out a process to make the transition smooth. You don't need to do anything, the PR will be merged to Alloy soon

codecapitano commented 2 months ago

Hey sorry for dragging this up, we just made the Alloy repo public and we need to redirect the PRs there. We will only be merging bugfixes to the agent from now on. We are just figuring out a process to make the transition smooth. You don't need to do anything, the PR will be merged to Alloy soon

Great, thank you so much 🙏

github-actions[bot] commented 1 month ago

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it. If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!

codecapitano commented 3 weeks ago

Hi @wildum any updates on this? We have customers running into this issue.

wildum commented 3 weeks ago

Hey, super sorry we actually moved all the issues but not the PRs and I forgot about it. Actually this seems to be relevant for the agent as it looks more like a bugfix than an enhancement. I can merge this PR and create a new one in Alloy and get it merged. Is that ok?

wildum commented 3 weeks ago

here is the alloy PR: https://github.com/grafana/alloy/pull/991. I extended a unit test to check that the float values had the prefix

wildum commented 3 weeks ago

merged in Alloy, I will also merge it in a bit to the agent

codecapitano commented 3 weeks ago

merged in Alloy, I will also merge it in a bit to the agent

Great thank you so much @wildum 🙏

wildum commented 3 weeks ago

All done, sorry again for the unnecessary delay!

codecapitano commented 3 weeks ago

Thank you so much and no worries. I think your team had a ton of work around Alloy release time. Ans I could've asked earlier as well.