search

grafana / agent

Vendor-neutral programmable observability pipelines.
https://grafana.com/docs/agent/
Apache License 2.0
1.59k stars 486 forks source link

feat(prometheus/operator): accept relabel rules exported from `prometheus.relabel` #6830

Open hainenber opened 5 months ago

hainenber commented 5 months ago

PR Description

Which issue(s) this PR fixes

Closes grafana/alloy#192

Notes to the Reviewer

PR Checklist

github-actions[bot] commented 4 months ago

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it. If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!

rfratto commented 3 months ago

Hey @hainenber, sorry for leaving you hanging for so long here :disappointed: Unfortunately I'm not sure about the proposed functionality in https://github.com/grafana/alloy/issues/192, so I'm holding off on reviewing this from an implementation standpoint.

We've recently introduced a new proposal review process that will help make it easier to understand when things still need discussion and when they're ready for work.

I'm going to mark grafana/alloy#192 as a proposal so it can be discussed and we can reach consensus on whether this is something we want to do.

hainenber commented 3 months ago

No worries! It's always good having more opinions to a proposed addition. More code means more debts after all 🤤

rfratto commented 3 months ago

Feel free to chime in for any proposal you think we should do, we want to welcome opinions from everyone and not just maintainers :)

github-actions[bot] commented 2 months ago

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it. If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!