patch2: Remove real keys from testing

grafana / agent

Vendor-neutral programmable observability pipelines.

https://grafana.com/docs/agent/

Apache License 2.0

1.59k stars 486 forks source link

Closed liamcreagh closed 5 months ago

liamcreagh commented 5 months ago

Even when testing you should never commit real keys to VCS. Especially private keys.

CLAassistant commented 5 months ago

All committers have signed the CLA.

rfratto commented 5 months ago

As far as I know these were keypairs generated specifically for the test, and aren't used in any environment.

I don't see the security harm of tests using keys generated specifically for testing. Can you help me understand what the risk is here?