search

grafana / agent

Vendor-neutral programmable observability pipelines.
https://grafana.com/docs/agent/
Apache License 2.0
1.59k stars 486 forks source link

Why agent requires adm group on deb package? #7005

Open gcb opened 1 month ago

gcb commented 1 month ago

What's wrong?

seeing https://github.com/grafana/agent/issues/524 and the fix https://github.com/grafana/agent/issues/737

files moved around, new location at https://github.com/rfratto/agent/blob/main/packaging/grafana-agent/deb/control/postinst#L23 still without explanation

instead of simply adding the user to the journald reader permission group systemd-journal, it is also added to adm group with no further explanation why.

adm is usually not required to read logs and can act on a lot more in regular setups.

Steps to reproduce

  1. install
  2. remove user from group
  3. nothing bad happens as far as i can tell.

System information

No response

Software version

No response

Configuration

No response

Logs

No response

github-actions[bot] commented 4 days ago

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it. If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!

gcb commented 1 day ago

any functionality is impacted that I am missing?