grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines
https://grafana.com/oss/alloy
Apache License 2.0
968 stars 103 forks source link

Feat: Add Catchpoint Exporter #1027

Closed BominRahmani closed 1 week ago

BominRahmani commented 2 weeks ago

PR Description

The following adds the Catchpoint Exporter in Alloy. The exporter was created with the intention of supporting the Grafana Catchpoint integration. The exporter is fairly stable, and I wouldn't expect any further changes unless users wanted more metrics.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

BominRahmani commented 1 week ago

@mattdurham @wildum @clayton-cornell Could any of you guys take another look at this?

mattdurham commented 1 week ago

Minor nit on go.mod but looks good. Resolve the conflict and I will merge. Thanks!

mattdurham commented 1 week ago

I noticed @clayton-cornell hasnt signed off so will let him give another review before merging.

clayton-cornell commented 1 week ago

Docs look OK now.

One other comment, @wildum suggested this should be flagged experimental was that done? If so we need to add {{< docs/shared lookup="stability/experimental.md" source="alloy" version="<ALLOY_VERSION>" >}} to the component doc

clayton-cornell commented 1 week ago

@mattdurham All docs questions are answered now. :-) Good to merge from docs side of things

BominRahmani commented 1 week ago

@mattdurham Any chance you can take a last look at this?

clayton-cornell commented 1 week ago

@mattdurham Merging - we have a green build pipeline and with your approval and docs approval it should be good to go.

mattdurham commented 6 days ago

Thanks @clayton-cornell , apologies @BominRahmani we had a holiday in USA yesterday.