search

grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines
https://grafana.com/oss/alloy
Apache License 2.0
1.25k stars 157 forks source link

Breaking changes to component.InstanceID #1323

Open mwear opened 1 month ago

mwear commented 1 month ago

There is an in-progress PR to make component.InstanceID immutable in collector core. It is currently a struct with all fields exported. The fields will only be accessible by getter methods going forward. Here are the occurrences of component.InstanceID in this repo: https://github.com/search?q=repo%3Agrafana%2Falloy%20component.InstanceID&type=code

I believe the only thing that will have to change is:https://github.com/grafana/alloy/blob/287775c7545a648e054d4fcf15f2f2ad03b75aa7/internal/converter/internal/otelcolconvert/utils.go#L14-L16

The change that will need to be made is below:

func StringifyInstanceID(id component.InstanceID) string {
    return fmt.Sprintf("%s/%s", StringifyKind(id.Kind()), id.ComponentID())
}
wildum commented 1 month ago

Thanks for the heads up, we will make the change when we update our dependency to a version of the collector that contains the change :)

github-actions[bot] commented 2 weeks ago

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it. If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!