grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines
https://grafana.com/oss/alloy
Apache License 2.0
1.33k stars 182 forks source link

Support configuring agent clusterRole permission in values.yaml #196

Open raphaelfan opened 6 months ago

raphaelfan commented 6 months ago

Request

In the agent helm chart, the clusterRole perm are configured in https://github.com/grafana/agent/blob/main/operations/helm/charts/grafana-agent/templates/rbac.yaml. Depending on the components used, the user may not need all the permissions. Please make the perm configurable from values.yaml.

Use case

Allow users to configure clusterRole permissions based on the flow mode Components used in the agent.

raphaelfan commented 5 months ago

Hi, @hainenber, will you recreate the pull request for this feature in the alloy project? Thanks.

hainenber commented 5 months ago

Sure, I'll port it to Alloy repo. Missed this one out

raphaelfan commented 5 months ago

Thank you!

raphaelfan commented 4 months ago

Hi @hainenber , it looks like all the checks in the PR passed, do you have a rough idea when this will be reviewed and merged? Thanks.

hainenber commented 4 months ago

I'm not sure tbh. It's up to the maintainers for now

raphaelfan commented 4 months ago

Thanks for the update, hope it will get reviewed soon.

raphaelfan commented 2 months ago

Hi @hainenber , any news from the maintainers? Thanks.

raphaelfan commented 1 week ago

Hi @hainenber , how is this going? thanks.