search

grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines
https://grafana.com/oss/alloy
Apache License 2.0
1.25k stars 156 forks source link

Component prometheus.scrape escape commas as %2C in param values passed with __param_name #205

Open outofsight opened 5 months ago

outofsight commented 5 months ago

What's wrong?

For example, given a prometheus.scrape component a target with:

    __metrics_path__                                                      = "/minio/metrics/v3/api/bucket",
    __param_buckets                                                       = "grafana-loki,grafana-loki-scalable,grafana-loki-scalable-ruler,grafana-mimir,grafana-mimir-blocks",

the Debug info/target view of Grafana Agent show the following scraping url:

"http://10.0.12.143:9000/minio/metrics/v3/cluster/usage/buckets?buckets=grafana-loki%2Cgrafana-loki-scalable%2Cgrafana-loki-scalable-ruler%2Cgrafana-mimir%2Cgrafana-mimir-blocks"

This of course doesn't work.

Something similar occurs also with prometheus.exporter.snmp and config_file making impossible to pass more than one config and splitting config and secrets.

Steps to reproduce

As above

System information

Linux 4.4.302+ x86_64 GNU/Linux + Docker

Software version

Grafana Agent v0.40

Configuration

No response

Logs

No response

rfratto commented 4 months ago

Hi there :wave:

On April 9, 2024, Grafana Labs announced Grafana Alloy, the spirital successor to Grafana Agent and the final form of Grafana Agent flow mode. As a result, Grafana Agent has been deprecated and will only be receiving bug and security fixes until its end-of-life around November 1, 2025.

To make things easier for maintainers, we're in the process of migrating all issues tagged variant/flow to the Grafana Alloy repository to have a single home for tracking issues. This issue is likely something we'll want to address in both Grafana Alloy and Grafana Agent, so just because it's being moved doesn't mean we won't address the issue in Grafana Agent :)

github-actions[bot] commented 3 months ago

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it. If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!