grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines
https://grafana.com/oss/alloy
Apache License 2.0
1.45k stars 216 forks source link

Add otelcol.receiver.solace #2084

Closed wildum closed 1 week ago

wildum commented 1 week ago

PR Description

Add the solace receiver from the Otel contrib repo: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/solacereceiver

Which issue(s) this PR fixes

Fixes #1993

Notes to the Reviewer

A few things to note:

PR Checklist

thampiotr commented 1 week ago

The upstream component has a retry policy when the next component fails to consume it.

That's odd, no? Any idea why did they add this? Shouldn't this be something done on the runtime level?

wildum commented 1 week ago

That's odd, no? Any idea why did they add this? Shouldn't this be something done on the runtime level?

Yet not a fan of this + it makes their implementation much more complex. This was done 2 years ago, maybe they wanted some extra safety because the component might be spamming a lot? They did not add any other flow control strategy since then but there is also no way around it.