search

grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines
https://grafana.com/oss/alloy
Apache License 2.0
1.45k stars 216 forks source link

feat: OpenTelemetry syslog exporter #2132

Closed dehaansa closed 6 hours ago

dehaansa commented 6 days ago

PR Description

Add support for the syslog exporter from OpenTelemetry to Alloy. There are several user requests for this component with varying requirements. The upstream component is in alpha stability, but does not appear to be unstable at this point in time.

Which issue(s) this PR fixes

https://github.com/grafana/alloy/issues/312

Notes to the Reviewer

There is significant data-massaging required to use this component well. I attempted to provide good examples in the docs, but this is definitely a good use case for better docs & task based docs moving forward. If there's anything in the docs that feels insufficient please raise it and I'll address.

PR Checklist

clayton-cornell commented 5 days ago

Docs look ok. I guess it over to someone else on the team for a code review?

dehaansa commented 4 days ago

LGTM, only comment I would have is it would be nice to have live debugging. Might be reasonable to do that in a separate PR though.

I'm happy to look at live debugging support in this PR or immediate followup, either is fine with me.

wildum commented 3 days ago

I'm happy to look at live debugging support in this PR or immediate followup, either is fine with me.

Otel exporters don't support live debugging yet. To add it you would need to plug it to the common exporter struct so that all Otel exporters get it. Because it would impact all exporters, it should be in a dedicated PR