search

grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines
https://grafana.com/oss/alloy
Apache License 2.0
1.25k stars 157 forks source link

Resync defaults for otelcol.extension.jaeger_remote_sampling with upstream #219

Open tpaschalis opened 5 months ago

tpaschalis commented 5 months ago

In our fork of the jaeger_remote_sampling extension we define the default http and grpc endpoints as

https://github.com/grafana/agent/blob/2603bda1660254f57f22e42ac3b47ab2ef58eb6e/internal/component/otelcol/extension/jaeger_remote_sampling/internal/jaegerremotesampling/factory.go#L44-L52

whereas the upstream code either adds 0.0.0.0 or localhost as a prefix based on a feature flag.

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/a7ffded40d597a6c3e1f3e755f3cb9135778e5bc/internal/common/localhostgate/featuregate.go#L52-L58

Let's not forget to update the defaults once we update our OpenTelemetry dependency.

cc @ptodev

github-actions[bot] commented 3 months ago

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it. If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!