grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines
https://grafana.com/oss/alloy
Apache License 2.0
1.4k stars 203 forks source link

grafana agent flow vs windows_exporter process collector #239

Open DavidSkDerivco opened 8 months ago

DavidSkDerivco commented 8 months ago

What's wrong?

w3wp processes do not have iis process names when collecting when running Grafana Agent Flow v0.39.1 Example when running windows_exporter v0.24.0 - windows_process_cpu_time_total{creating_process_id="1234",mode="user",process="_w3wpDefaultAppPool",process_id="123456"} Example running Grafana Agent Flow v0.39.1 - windows_process_cpu_time_total{creating_process_id="1234",mode="user",process="w3wp",process_id="12345"} 111.8125

Steps to reproduce

Install Grafana Agent Flow v0.39.1 and compare with install of windows_exporter v0.24.0 Check "windows_process" metrics

System information

Windows Server 2019

Software version

Grafana Agent Flow v0.39.1

Configuration

prometheus.exporter.windows "os_metrics" {
  enabled_collectors = ["process","iis"]
  process {
    include = "Idle|w3w.*|grafana.+"
  }
}

Logs

No logs on this event
jaco-van-zyl-derivco commented 8 months ago

It does not look like the flag is available in the grafana agent config

--collector.process.iis
Enables IIS process name queries. IIS process names are combined with their app pool name to form the process label.
Disabled by default, and can be enabled with --collector.process.iis=true.
tpaschalis commented 8 months ago

Looks like @jaco-van-zyl-derivco is right, we haven't wired this new config field and only have include/exclude. Would any of you be interested in wiring this in?

jaco-van-zyl-derivco commented 8 months ago

I am happy to attempt this addition

github-actions[bot] commented 7 months ago

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it. If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!

jaco-van-zyl-derivco commented 7 months ago

Awaiting a new build of the windows_exporter

rfratto commented 6 months ago

Hi there :wave:

On April 9, 2024, Grafana Labs announced Grafana Alloy, the spirital successor to Grafana Agent and the final form of Grafana Agent flow mode. As a result, Grafana Agent has been deprecated and will only be receiving bug and security fixes until its end-of-life around November 1, 2025.

To make things easier for maintainers, we're in the process of migrating all issues tagged variant/flow to the Grafana Alloy repository to have a single home for tracking issues. This issue is likely something we'll want to address in both Grafana Alloy and Grafana Agent, so just because it's being moved doesn't mean we won't address the issue in Grafana Agent :)